Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] account_invoice_line_sequence: change from post_init_hook to pr… #4

Draft
wants to merge 1 commit into
base: 11.0-performance
Choose a base branch
from

Conversation

ACheung-FactorLibre
Copy link

…e_init_hook and its functionality

@JavierIniesta
Copy link

Please also change:

  • __init__.py: post_init_hook to pre_init_hook.
  • default value for max_line_sequence from 9999 to 1.

@JavierIniesta
Copy link

JavierIniesta commented Jun 8, 2023

Be careful with formatting. As it is an OCA module, try to introduce only the necessary changes, do not add formatting changes.

Do not remove the _compute_max_line_sequence method. Instead, call it with all invoices at the end of reset.

Copy link

@JavierIniesta JavierIniesta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ACheung-FactorLibre ACheung-FactorLibre force-pushed the 11.0-account_invoice_line_sequence branch 2 times, most recently from cd43e0a to b862620 Compare June 19, 2023 08:50
@ACheung-FactorLibre ACheung-FactorLibre force-pushed the 11.0-account_invoice_line_sequence branch from b862620 to beed583 Compare June 19, 2023 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants