-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Curves #266
base: master
Are you sure you want to change the base?
Curves #266
Conversation
Signed-off-by: mandar242 <[email protected]>
Signed-off-by: mandar242 <[email protected]>
Signed-off-by: mandar242 <[email protected]>
Why no tests? Not sure why you're returning a pointer for |
Ok i ll make some test just for sake of it. Lets remove these pointers then. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Bezier functions/structures look good, was there a reason why you needed to change the pixelgl.Window structure to directly embed the glfh.Window structure?
|
I assume this PR is not relevant anymore. |
@duysqubix could still be useful, I would suggest we revert the window.go changes. But other than those, lgtm |
This commit adds beizer curves to geometry and also adds one method for vector Angle to. Its all documentated. Curve should be used by a particle system i am planing to pull request.