Skip to content

Handle CheckCert Correctly for OTLP Outputs#1287

Open
rrhubenov wants to merge 1 commit intofalcosecurity:masterfrom
rrhubenov:fix_checkert_otlp
Open

Handle CheckCert Correctly for OTLP Outputs#1287
rrhubenov wants to merge 1 commit intofalcosecurity:masterfrom
rrhubenov:fix_checkert_otlp

Conversation

@rrhubenov
Copy link

@rrhubenov rrhubenov commented Nov 25, 2025

What type of PR is this?
/kind bug

/area outputs

What this PR does / why we need it:
The OTLP outputs, when configured with CheckCert: false would use an Insecure option, which results in TLS plaintext communication rather than the expected, which is TLS but without checking the validity of the server certificate.

This PR fixes this issue by passing the correct option to achieve the desired correct effect.
This PR also fixes a bug where the Traces.CheckCert field was checked for the Logs output rather than Logs.CheckCert.
Which issue(s) this PR fixes:

NONE

Special notes for your reviewer:

Signed-off-by: Radoslav Hubenov <rrhubenov@gmail.com>
@poiana
Copy link

poiana commented Nov 25, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rrhubenov
Once this PR has been reviewed and has the lgtm label, please assign leogr for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana requested a review from leogr November 25, 2025 09:42
@poiana
Copy link

poiana commented Nov 25, 2025

Welcome @rrhubenov! It looks like this is your first PR to falcosecurity/falcosidekick 🎉

@poiana poiana added the size/M label Nov 25, 2025
@poiana
Copy link

poiana commented Feb 23, 2026

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

@leogr
Copy link
Member

leogr commented Feb 26, 2026

/remove-lifecycle stale

@leogr
Copy link
Member

leogr commented Feb 27, 2026

Closing and reopening to trigger the CI
/close

@poiana poiana closed this Feb 27, 2026
@poiana
Copy link

poiana commented Feb 27, 2026

@leogr: Closed this PR.

Details

In response to this:

Closing and reopening to trigger the CI
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@leogr
Copy link
Member

leogr commented Feb 27, 2026

/reopen

@poiana poiana reopened this Feb 27, 2026
@poiana
Copy link

poiana commented Feb 27, 2026

@leogr: Reopened this PR.

Details

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @rrhubenov

Thank you for this PR. It SGTM, but I think that users who had CheckCert: false to talk to a non-TLS collector will break, since the client now attempts a TLS handshake.

We need either a new Insecure config field or just documenting the potential breaking change. Wdyt?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants