feat(settings): add toggle to protect conversation history from auto-deletion#1624
Open
daymade wants to merge 2 commits intofarion1231:mainfrom
Open
feat(settings): add toggle to protect conversation history from auto-deletion#1624daymade wants to merge 2 commits intofarion1231:mainfrom
daymade wants to merge 2 commits intofarion1231:mainfrom
Conversation
…deletion Claude Code silently deletes conversation transcripts after 30 days by default (cleanupPeriodDays: 30). Most users are unaware of this until they lose data (anthropics/claude-code#4172, #22547, #23710). Add a "Keep conversation history" toggle in Settings → General, below the existing "Skip Claude Code first-run confirmation" toggle. When enabled, sets cleanupPeriodDays: 99999 in ~/.claude/settings.json. The toggle syncs from Claude's actual settings.json on load, so it reflects reality even if the user edited the file manually. Closes farion1231#1623 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Owner
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3174941fdd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
- Auto-save handler: remove stale `data?.` comparison for skipClaudeOnboarding and keepConversationHistory — the `updates !== undefined` guard is sufficient and avoids skipping API calls when data hasn't refetched after rapid toggles - Explicit save handler: keep `data?.` comparison with clarifying comments — prevents premature clearTranscriptProtection() when async init hasn't completed yet - Add userTouchedTranscriptRef to prevent async getTranscriptProtection() from overwriting user's manual toggle choice Addresses review feedback from farion1231#1624. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Author
|
Hi @farion1231, I've pushed a fix commit ( Changes in the new commit
All changes pass |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cleanupPeriodDays: 99999in~/.claude/settings.jsonto prevent auto-deletionsettings.jsonon load, reflecting manual editsRoot Cause
Claude Code silently deletes conversation transcripts after 30 days by default. Users are unaware until they lose data. Multiple upstream issues:
Changes
Rust backend (3 files):
claude_mcp.rs:set_cleanup_period_days()/clear_cleanup_period_days()/get_cleanup_period_days()— reads/writes~/.claude/settings.jsoncommands/plugin.rs: 3 Tauri commandslib.rs: Command registrationFrontend (9 files):
WindowSettings.tsx: ToggleRow withHistoryicon (amber-500)useSettings.ts: Auto-save logic followingskipClaudeOnboardingpatternuseSettingsForm.ts: Field init + on-load sync from actual Claude settingssettings.ts/schemas/settings.ts/types.ts: Type definitionsen.json/zh.json/ja.json: i18n (3 locales)Why This Is Safe
skipClaudeOnboarding(proven, shipped)~/.claude/settings.json) is the official Claude Code settings filecleanupPeriodDays: 99999is the documented workaroundTesting
cargo checkpasses cleanlyCloses #1623
🤖 Generated with Claude Code