Skip to content

Reconstruct RBAC authentication logic #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Jan 8, 2024
Merged

Reconstruct RBAC authentication logic #264

merged 22 commits into from
Jan 8, 2024

Conversation

wu-clan
Copy link
Member

@wu-clan wu-clan commented Jan 4, 2024

PLR.

@wu-clan wu-clan requested a review from downdawn January 7, 2024 07:49
@wu-clan
Copy link
Member Author

wu-clan commented Jan 7, 2024

We mainly use casbin because the front end is already in use.

Casbiin is a more advanced access control, but the cost of learning will increase. If you have not been exposed to go web development, we do not recommend you to use it.

And I think that using the role menu RBAC, the front end will not need to do any extra processing, just menu permission identification, so simple.

@downdawn
Copy link
Collaborator

downdawn commented Jan 7, 2024

LGTM.

@wu-clan wu-clan merged commit 5c7d665 into fastapi-practices:master Jan 8, 2024
@wu-clan wu-clan deleted the refactor-rbac-auth branch January 8, 2024 01:35
@wu-clan wu-clan linked an issue Jan 14, 2024 that may be closed by this pull request
10 tasks
@wu-clan wu-clan removed a link to an issue Jan 14, 2024
10 tasks
@wu-clan wu-clan mentioned this pull request Jan 14, 2024
10 tasks
@wu-clan wu-clan linked an issue Jan 14, 2024 that may be closed by this pull request
10 tasks
@wu-clan wu-clan removed a link to an issue Jan 14, 2024
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants