upgrade deps and modernize naming conventions #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codereviewbot-ai[bot]](https://avatars.githubusercontent.com/in/309638?s=60&v=4){kind=small}
Comment on lines
+9
to
11
| bazel build //gitops/blaze_query:build_go_proto //gitops/analysis:analysis_go_proto | ||
| GEN_REPB_PATH="gitops/blaze_query/build.pb.go" | ||
| cp -f "$(find $(bazel info bazel-bin) -path "*/$GEN_REPB_PATH")" "$GEN_REPB_PATH" |
There was a problem hiding this comment.
The script uses bazel build to generate protobuf files and then copies the generated file using find. However, there is no error handling to check if the bazel build command or the find command fails. This could lead to silent failures and make debugging difficult.
Recommended Solution:
Add error handling after the bazel build command and the find command to ensure that any failures are caught and reported. This can be done by checking the exit status of the commands and printing an error message or exiting the script if they fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update go deps to more recent. Specifically, kubernetes client libraries are updated 0.26 -> 0.29