-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DT-340: Warn the user if they are leaving a story edit page with unsaved changes #334
Open
torresga
wants to merge
3
commits into
main
Choose a base branch
from
feature/DT-340-warn-user-unsaved-edits
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
cc06e42
Adds event listeners to listen for unsaved edits and alerting the use…
torresga 7051f15
Adds spec to test for presence of alert when we try to navigate away …
torresga 7b5afd6
Refactored the code to only add the event listeners on the form if th…
torresga File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -25,8 +25,57 @@ document.addEventListener("DOMContentLoaded", () => { | |||||
debounceTimer = window.setTimeout(updateMarkdown, 300); | ||||||
}); | ||||||
}); | ||||||
|
||||||
const form = document.querySelector(".edit_story"); | ||||||
const backButton = document.getElementById("back"); | ||||||
const logo = document.getElementById("logo"); | ||||||
let isDirty = false; | ||||||
|
||||||
if (form) { | ||||||
// Mark the form as dirty when any input changes | ||||||
form.addEventListener("input", function () { | ||||||
isDirty = true; | ||||||
addBeforeUnloadEventListener(isDirty); | ||||||
}); | ||||||
|
||||||
// Reset isDirty on form submission | ||||||
form.addEventListener("submit", function () { | ||||||
isDirty = false; | ||||||
addBeforeUnloadEventListener(isDirty); | ||||||
}); | ||||||
} | ||||||
|
||||||
// Attach a click event to the custom back button | ||||||
[backButton, logo].forEach(element => { | ||||||
element.addEventListener("click", function (event) { | ||||||
if (isDirty) { | ||||||
const confirmLeave = confirm("You have unsaved changes. Are you sure you want to go back?"); | ||||||
if (!confirmLeave) { | ||||||
// Prevent navigation if the user chooses not to leave | ||||||
event.preventDefault(); | ||||||
} else { | ||||||
// Optionally, reset isDirty if leaving | ||||||
isDirty = false; | ||||||
addBeforeUnloadEventListener(isDirty) | ||||||
} | ||||||
} | ||||||
}) | ||||||
}); | ||||||
}); | ||||||
|
||||||
function addBeforeUnloadEventListener(isDirty) { | ||||||
if (isDirty) { | ||||||
window.addEventListener("beforeunload", warnUserifUnsavedEdits); | ||||||
} else { | ||||||
window.removeEventListener("beforeunload", warnUserifUnsavedEdits); | ||||||
} | ||||||
} | ||||||
|
||||||
function warnUserifUnsavedEdits(event) { | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. A bit picky, you might missed the
Suggested change
|
||||||
event.preventDefault(); | ||||||
event.returnValue = ''; | ||||||
} | ||||||
|
||||||
function updateStatusButton(color, status) { | ||||||
const button = document.querySelector(".story-title .dropdown-wrapper > button"); | ||||||
button.className = `button ${color}`; | ||||||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find it easier to read
confirmLeave
compared to!confirmLeave
, as it always takes me a moment to grasp the condition.