-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dual boot 7.0 and 7.1 #103
base: main
Are you sure you want to change the base?
Conversation
I added a bug report in the skunk repo, it's failing because the skunk score improved #104 (not really an improvement for any particular file, but we have more files now so the average improved) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@arielj I see that the new framework defaults are commented. Shouldn't we try with new framework defaults to see if everything works as expected?
Please let me know
We could, it's not something required though (it could be done after the upgrade in another PR, the Rails docs recommend doing that over time and multiple deployments https://guides.rubyonrails.org/upgrading_ruby_on_rails.html#configure-framework-defaults). So it's not needed, but I can try that (we have to consider that there are some changes there that require extra changes, like changing the encryption key requires adding a cookie rotator that has to be removed in the future https://github.com/fastruby/skunk.fyi/pull/103/files#diff-eea1c50635a8c62e2b5a61e4e6526c06b9a172c2c7eb6e071dc4b42722b8d5f6R19-R26 ) I do think skunk.fyi is so simple that it's probably safe to just change the maybe we need another PR/story to upgrade the defaults gradually? |
@arielj Would you kindly settle merge conflicts so that we can proceed to Rails 7? cc @etagwerker |
Description:
This PR updates the app to use 7.0 and dual boot with 7.1.
I also updated some config files based on changes from running
rails app:update
I will abide by the code of conduct.