fix: quote filenames when making registries - #546
Open
binggao1230 wants to merge 1 commit into
Open
Conversation
Author
|
The failing test jobs look unrelated to this change. In each failed job, the new regression test passes: The failures are all from the existing I tried to rerun failed jobs, but GitHub does not allow me to rerun checks on the upstream repo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #369.
Pooch.load_registryalready usesshlex.split, so filenames with spaces can be read when they are quoted.make_registrywas still writing raw filenames, which made generated registries ambiguous for names likeLICENSE (copy).This updates
make_registryto quote the normalized registry filename withshlex.quoteand adds a round-trip test for a filename containing spaces.Verification: