Skip to content

Android: Resolve issues on Android with deprecated API. #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Android: Resolve issues on Android with deprecated API. #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8f783de
Fix deprecation warning on Android
cyrillkuettel Feb 18, 2023
8f0c916
plugins require a higher Android SDK version to build
cyrillkuettel Feb 18, 2023
ebfb967
Fix conflict in Android dependencies
cyrillkuettel Feb 18, 2023
64d7ef5
Update to non-deprecated api
cyrillkuettel Feb 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions android/src/main/java/io/fynn/pytorch_mobile/PyTorchMobilePlugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,8 @@ public class PyTorchMobilePlugin implements FlutterPlugin, MethodCallHandler {

@Override
public void onAttachedToEngine(@NonNull FlutterPluginBinding flutterPluginBinding) {
final MethodChannel channel = new MethodChannel(flutterPluginBinding.getFlutterEngine().getDartExecutor(),
"pytorch_mobile");
final MethodChannel channel = new
MethodChannel(flutterPluginBinding.getBinaryMessenger(), "pytorch_mobile");
channel.setMethodCallHandler(new PyTorchMobilePlugin());
}

Expand Down
2 changes: 1 addition & 1 deletion example/android/app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ apply plugin: 'com.android.application'
apply from: "$flutterRoot/packages/flutter_tools/gradle/flutter.gradle"

android {
compileSdkVersion 28
compileSdkVersion 31

lintOptions {
disable 'InvalidPackage'
Expand Down
2 changes: 1 addition & 1 deletion example/android/app/src/main/AndroidManifest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
additional functionality it is fine to subclass or reimplement
FlutterApplication and put your custom class here. -->
<application
android:name="io.flutter.app.FlutterApplication"
android:name="${applicationName}"
android:label="pytorch_mobile_example"
android:icon="@mipmap/ic_launcher">
<activity
Expand Down
Loading