This repository was archived by the owner on May 5, 2021. It is now read-only.
Do Not Merge: Proposed idea around code partial#26
Open
willium wants to merge 4 commits intofbrctr:masterfrom
willium:master
Open
Do Not Merge: Proposed idea around code partial#26willium wants to merge 4 commits intofbrctr:masterfrom willium:master
willium wants to merge 4 commits intofbrctr:masterfrom
willium:master
Conversation
Member
|
Hey! I'm not totally sure what functionality this adds. Do you mind posting a more concrete example of how you're using this functionality? |
Author
|
Hey @lukeaskew, this gist might make it more clear |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I want to present my 'example code' sans any grid I implement. within my code I have an extra stylesheet where I added a grid. for presenting icons on the style guide. Of course, they shouldn't be shown to people who are implementing the style guide (as they aren't available within the compressed css). Therefore I needed a separate partial for only showing the code. My f-item-content looks like
to better understand. This isn't implemented well, however, so I don't propose this change be merged. However, I'd be interested to know about a potential proper implementation of this kind of use-case within fabricator.