viewer: ignore UTF-8 errors #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to a bug in dnf invalid UTF-8, make sure the viewer does not choke on them. See: rpm-software-management/dnf5#1865 for details. Example of the failure from https://artifacts.dev.testing-farm.io/c7a1bbdd-1c91-44a9-87ba-f2b9f6fe7dc3/: ``` 18:24:51 out: Running transaction 18:24:51 out: [1/2] Prepare transaction 100% | 62.0 B/s | 1.0 B | 00m00s 18:24:51 out: [2/2] Removing spamassassin-debugsource 100% | 147.0 B/s | 9.0 B | 00m00s 18:24:51 out: Complete! 18:24:51 out: remove result: fail (status code: 1) 18:24:51 out: Traceback (most recent call last): 18:24:51 out: File "/usr/libexec/mini-tps/viewer/generate-result-json", line 53, in <module> 18:24:51 out: "details": log.read_text(), 18:24:51 out: ~~~~~~~~~~~~~^^ 18:24:51 out: File "/usr/lib64/python3.13/pathlib/_local.py", line 546, in read_text 18:24:51 out: return PathBase.read_text(self, encoding, errors, newline) 18:24:51 out: ~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 18:24:51 out: File "/usr/lib64/python3.13/pathlib/_abc.py", line 633, in read_text 18:24:51 out: return f.read() 18:24:51 out: ~~~~~~^^ 18:24:51 out: File "<frozen codecs>", line 325, in decode 18:24:51 out: UnicodeDecodeError: 'utf-8' codec can't decode bytes in position 19977-19978: invalid continuation byte 18:24:51 out: running in TMT, wrote /var/ARTIFACTS/work-installability513gxf67/installability/execute/data/guest/default-0/installability-2/data/results.yaml 18:24:51 out: mtps-run-tests overall result: fail (status code: 1) 18:24:51 out: Shared connection to 18.221.80.14 closed. ``` Signed-off-by: Miroslav Vadkerti <[email protected]>
msrb
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a bug in dnf invalid UTF-8, make sure the viewer does not choke on them.
See:
rpm-software-management/dnf5#1865
for details.
Example of the failure from
https://artifacts.dev.testing-farm.io/c7a1bbdd-1c91-44a9-87ba-f2b9f6fe7dc3/: