frontend: provide log-detective explain integration for failed builds #3608
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
nikromen
force-pushed
the
log-detective-integration
branch
from
d51316c to
b9793b7
Compare
| <a href="{{ failed_build_log_url | format(url) }}" class="btn btn-default btn-xs"> | ||
| <span class="pficon pficon-info"></span> Explain with Log Detective AI | ||
| </a> | ||
| {% endif %} |
There was a problem hiding this comment.
Can we place this into a separate column, since this is not a log file but "request for explanation".
There was a problem hiding this comment.
Or, maybe we could have a clickable "failed" state? Can you upload a screenshot?
| @@ -157,6 +157,12 @@ | |||
| <span class="pficon pficon-ok"></span> {{ state }} | |||
| {% elif state == "failed" %} | |||
| <span class="pficon pficon-error-circle-o"></span> {{ state }} | |||
| {% if failed_build_log_url and config.LOG_DETECTIVE_BUTTON %} | |||
There was a problem hiding this comment.
The used config option is ON in prod, and we want to keep this new UI disabled for some time... I think we need yet another option.
There was a problem hiding this comment.
Maybe not, it will be quite some time before we'll do a new Copr release anyway.
|
|
||
| Returns: | ||
| the full URL to the log file or None if the log file does not exist | ||
| """ |
There was a problem hiding this comment.
🤷 this rewrite is weird, can we have a separate method for the new link?
There was a problem hiding this comment.
Or IMHO even better, can we improve log detective to handle the compressed logs?
|
Would you mind uploading the screenshot? |
nikromen
force-pushed
the
log-detective-integration
branch
from
b9793b7 to
42a89fa
Compare
nikromen
changed the title
|
button next to the fail state: srpm failure rpm failure or 793ee5b introduces separate column for the table separated column when rpm build fails no separated column created when srpm fails |
nikromen
force-pushed
the
log-detective-integration
branch
from
42a89fa to
793ee5b
Compare
nikromen
force-pushed
the
log-detective-integration
branch
from
793ee5b to
e079ab3
Compare
|
IMHO the buttons come out too aggressive. I would probably go with a normal link and an icon (to look the same as the chroot name in the first column). And I would probably shorten the text to something like "Explain failure" or "Explain with AI". |
|
like this?
|
|
From the meeting: [x] failed (Ask AI / Teach AI) |
Pull Request validationFailed🔴 Review - Missing review from a member (2 required) Success🟢 CI - All checks have passed |
Merge after fedora-copr/logdetective-website#207