Accessibility - #84
Merged
Merged
Conversation
matthiask
reviewed
May 29, 2026
| buttonWrapper, | ||
| picker, | ||
| ]) | ||
| const optionButtons = new Map() |
Member
There was a problem hiding this comment.
I'm not sure why the map is needed, can you remind me? I think we discussed this already but I have forgotten the reasoning.
Contributor
Author
There was a problem hiding this comment.
After wrapping, the direct child is the wrapper button, not item.option. So toggling hidden on item.option would only hide the inner element while leaving an empty visible row in the dropdown.
Member
There was a problem hiding this comment.
Makes sense, thank you! I'll test it today and then publish a release if I don't find any problems (I don't expect any)
Contributor
Author
|
I think you need to revert 14baa88 first before you can merge it |
# By Matthias Kestenholz (3) and pre-commit-ci[bot] (2) # Via GitHub * main: [pre-commit.ci] pre-commit autoupdate (#83) Updates Updates [pre-commit.ci] pre-commit autoupdate (#82) Update dependencies # Conflicts: # django_prose_editor/static/django_prose_editor/editor.css.map # django_prose_editor/static/django_prose_editor/editor.js # django_prose_editor/static/django_prose_editor/editor.js.map # django_prose_editor/static/django_prose_editor/overrides.css.map
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.