Skip to content

Commit 10ee019

Browse files
committed
Fix PHP 8.1 "strlen(null)" exception setting Passphrase Credential
Summary: `strlen()` was used in Phabricator to check if a generic value is a non-empty string. This behavior is deprecated since PHP 8.1. Phorge adopts `phutil_nonempty_string()` as a replacement. Note: this may highlight other absurd input values that might be worth correcting instead of just ignoring. If phutil_nonempty_string() throws an exception in your instance, report it to Phorge to evaluate and fix that specific corner case. ``` EXCEPTION: (RuntimeException) strlen(): Passing null to parameter freebsd#1 ($string) of type string is deprecated at [<arcanist>/src/error/PhutilErrorHandler.php:261] arcanist(head=master, ref.master=788098096e11), phorge(head=master, ref.master=840a7fab2bc8) #0 <freebsd#2> PhutilErrorHandler::handleError(integer, string, string, integer) called at [<phorge>/src/applications/passphrase/view/PassphraseCredentialControl.php:53] ``` Closes T15580 Test Plan: Set URI for a Diffusion Repository, select URI and select "Set Credential". Page "Edit Repository URI" at `/diffusion/123/uri/edit/456/` renders as expected in web browser. Reviewers: O1 Blessed Committers, Matthew Reviewed By: O1 Blessed Committers, Matthew Subscribers: avivey, speck, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno Maniphest Tasks: T15580 Differential Revision: https://we.phorge.it/D25370
1 parent eb0bb17 commit 10ee019

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

src/applications/passphrase/view/PassphraseCredentialControl.php

+2-1
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,8 @@ protected function renderInput() {
5050
// credential. Populate it into the menu to allow them to save the form
5151
// without making any changes.
5252
$current_phid = $this->getValue();
53-
if (strlen($current_phid) && empty($options_map[$current_phid])) {
53+
if (phutil_nonempty_string($current_phid) &&
54+
empty($options_map[$current_phid])) {
5455
$viewer = $this->getViewer();
5556

5657
$current_name = null;

0 commit comments

Comments
 (0)