Randomize local server port#485
Draft
execjosh wants to merge 1 commit into
Draft
Conversation
Make the port of the local server harder to guess, which will help prevent naïve exploitation of the privilege escalation threat posed by the `/run/` endpoint. This can be circumvented by inspecting the command line of the process, or scanning all the local ports, to discover the correct port; however, it is better than nothing.
execjosh
force-pushed
the
randomize-local-server-port
branch
from
e2e1db0 to
a568b98
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the port of the local server harder to guess, which will help prevent naïve exploitation of the privilege escalation threat of the
/run/endpoint. This can be circumvented by inspecting the command line of the process, or scanning all the local ports, to discover the correct port; however, it is better than nothing.One concern is how to handle the CORS proxy. Making its port unpredictable is probably suboptimal. However, the server currently uses the provided port plus one for CORS, which would not be
41417anyway if41416were to have already been in use when Übersicht started up. Randomizing the port would make such an edge case the normal case.