addpatch: grilo-plugins 0.3.18-1 #4907
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xeonacid
reviewed
Aug 29, 2025
grilo-plugins/riscv64.patch
Outdated
| - dbus-run-session meson test -C build --print-errorlogs | ||
| + local skip_tests='test_lua_theaudiodb|test_chromaprint_resolve' | ||
| + local tests_to_run=$(meson test --list -C build | grep -E -v "$skip_tests") | ||
| + dbus-run-session meson test -C build --no-rebuild --print-errorlogs ${tests_to_run} |
There was a problem hiding this comment.
Wondering if --no-rebuild is mandatory for a successful build?
There was a problem hiding this comment.
No, should I remove it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
skip two test.
test_lua_theaudiodb is an old issue to the upstream that havn't be solved.upstreamedUsed to get data from TheAudioDB website, non-critical function.
test_chromaprint_resolve,the root cause of the failure is not in the grilo-plugins we are building. The gst-plugins-bad package required by the check depends on the old version of x265 when compiled. However, the arch repository in riscv later updated x265 but did not recompile gst-plugins-bad(?), resulting in ABI problem.and i skip this.