Draft for Nicks Review #30
Conversation
…ras-stac into feature/improve_tests
There was a problem hiding this comment.
General note for STAC extension schema JSON documents: the terms defined should follow the format of extension_alias:property_name. For example, with the proj extension, every property defined in that extension will be proceeded by proj (ex: proj:wkt2). In this document, the required properties have no extension alias and other properties have different aliases than one another
There was a problem hiding this comment.
For example, the term structures:lateral_structure_count and the term 2d_flow_areas:cell_minimum_size have 2 different aliases (structures and 2d_flow_areas), which means that they should be contained within 2 separate schemas (one for terms related to structures and one for terms related to 2d flow areas). I would suggest instead just using a single uniform alias
| "description": "Unit system used (ex. US Customary)." | ||
| }, | ||
| "plan_information:project_filename": { | ||
| "type": ["string", "null"], |
There was a problem hiding this comment.
Using this as an example of a property which has a type with the value "null" included - is the intention here to force the user to provide a plan_information:project_filename property every time that they use the extension, and in cases where there is no project filename to allow a null value?
If so, this property should be added to the required properties for the extension. If not, this property should just have the type "string" as that would basically say that when the property is defined, which it does not have to be, it should be a string.
| prj_ext.bbox = list(perimeter_polygon.bounds) | ||
| prj_ext.centroid = mapping(perimeter_polygon.centroid) | ||
|
|
||
| stor_ext = StorageExtension.ext(self, add_if_missing=True) |
There was a problem hiding this comment.
Will the items used by this class always have content on s3 and will the region always be us-east-1?
No description provided.