Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruff for linting/formatting #26

Merged
merged 8 commits into from
Apr 30, 2024
Merged

Ruff for linting/formatting #26

merged 8 commits into from
Apr 30, 2024

Conversation

thwllms
Copy link
Contributor

@thwllms thwllms commented Apr 30, 2024

Integrates ruff into the workflow for linting and automatic formatting.

  • Integrates ruff linting/formatting as a pre-commit hook
  • Includes ruff in CI workflow
  • Edits Python code based on linting issues and automatic changes from ruff

Also:

  • Adds some badges to the README indicating build status and current release version on PyPI
  • Refactors some tests in test_geom (note that these are basically the only human/non-ruff Python code edits)
  • Removes unused code in .devcontainer

Note that this update will require devs to update dependencies and install pre-commit hooks:

$ pip install ".[dev]"
$ pre-commit install

@thwllms thwllms requested review from bates-j and sray014 April 30, 2024 19:42
Copy link
Contributor

@sray014 sray014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@thwllms thwllms merged commit 909301a into main Apr 30, 2024
4 checks passed
@thwllms thwllms deleted the feature/ruff branch April 30, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants