feat: support control command#3
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a control message channel to the rad TCP protocol. LSP frames use
RadMessage::Lspas before; out-of-band control messages useRadMessage::Control. The entire pipeline is also lifted from rawVec<u8>to typedLspFrame/RadMessagestructs.Key changes
RadFrameCocdec(encode + decode). 5-byte header (1 byte kind + 4 bytes body len), JSON body. SupportsLspandControlmessage kinds.rad statuscommand — Client sendsStatusRequest, server responds with each instance's workspace, pid, clients, idle time, and health, printed in a human-readable format.InstanceManager::status()iterates all managed instances to collect runtime state.Vec<u8>toLspFrame(LSP layer) andRadMessage(protocol layer).RoutedPacket,ClientHandle, and related types use structured types, eliminating scattered serialization calls.to_clientchannel andforward_lsp_to_writerintermediate task. The instance layer only depends onsend(LspFrame), completely unaware ofRadMessage.read/write_alltoFramedRead/FramedWrite.