Repository navigation
fix: clean error when log directory creation fails - #358
Open
codythebeast89 wants to merge 1 commit into
Open
codythebeast89 wants to merge 1 commit into
codythebeast89 wants to merge 1 commit into
Conversation
Permission errors while creating `logs/` previously panicked via `unwrap()` on tracing-appender init. Propagate a thiserror result and exit with a plain stderr message instead (ferrumc-rs#352).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When the process cannot create or write the
logs/directory (for example, permission denied), FerrumC previously panicked onunwrap()during rolling-file appender init. Logging initialization now returns athiserrorresult, andmainprints a plain stderr message and exits with a non-zero status instead of a Rust panic.Motivation and Context
Fixes #352.
How has this been tested?
cargo test -p ferrumc-logging --libcargo clippy -p ferrumc-logging --all-targets --no-deps -- -D warningscargo fmt --all -- --checkcargo check -p ferrumcLoggingErrorDisplay text; Unix regression that an unwritable log dir returnsPermissionDeniedinstead of panickingScreenshots (if appropriate):
Types of changes
Checklist:
Made with Cursor