IMAT ngem transforms#662
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #662 +/- ##
==========================================
+ Coverage 96.64% 96.68% +0.04%
==========================================
Files 49 49
Lines 2148 2175 +27
==========================================
+ Hits 2076 2103 +27
Misses 72 72 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Pasarus
force-pushed
the
add_ngem_transforms
branch
from
2a49f66 to
176baf5
Compare
keiranjprice101
left a comment
keiranjprice101
left a comment
Collaborator
There was a problem hiding this comment.
Looks good, 2 minor questions
Pasarus
commented
Jun 1, 2026
Co-authored-by: Samuel Jones <samjones714@gmail.com>
Pasarus
commented
Jun 1, 2026
keiranjprice101
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes None, part of IMAT epic
Description
Adjust transforms to effectively allow 2 modes of reduction for IMAT, one uses nGEM and one uses the Mantid imaging 3D reconstruction.