Add support for ngem imat workflows#424
Open
Pasarus wants to merge 12 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #424 +/- ##
==========================================
- Coverage 97.58% 97.46% -0.12%
==========================================
Files 7 8 +1
Lines 497 671 +174
==========================================
+ Hits 485 654 +169
- Misses 12 17 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
keiranjprice101
left a comment
keiranjprice101
left a comment
Collaborator
There was a problem hiding this comment.
I have only had time for a partial review, but left a single comment. I will try again later sorry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes None, part of the IMAT/nGEM epic
Description
Adds a new endpoint we can connect to that holds the ngem data for imat runs, also ensures that the ngem runs use mantid not mantid imaging, and have the correct taints for those workflows.