Replace HTTPException with JSONResponse for consistent error hand…#364
Merged
Conversation
keiranjprice101
force-pushed
the
fix_livedata_middleware
branch
from
ce4a106 to
9469ab6
Compare
eva-1729
approved these changes
May 11, 2026
eva-1729
left a comment
eva-1729
left a comment
Collaborator
There was a problem hiding this comment.
All tests pass and makes sense logically
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HTTPExceptions will always have a 500 status code if raised inside a middleware, unlike a route. This instead returns a JSONResponse to guarantee the correct status code