Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for PHP mongodb extension #550

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add support for PHP mongodb extension #550

wants to merge 1 commit into from

Conversation

hussainweb
Copy link

This adds support for the mongodb PHP extension which replaces the old mongo extension. The default is still the old extension which can be changed with a variable.

Again, since the default is the extension which is currently installed, I hope this counts as a minor feature and gets in quickly.

@fideloper
Copy link
Owner

Any reason not to assume people will use the more modern extension and go with that? That'd be my preference for Vaprobash, but I haven't touched Mongo in years.

@hussainweb
Copy link
Author

The modern extension is not backward compatible, AFAIK. If you have an app built with the old extension, you likely want that. Changing the default would count as a breaking change. Also, in contributing doc, you say that this is using semver which would mean changing the default should go to 2.0.0.

I thought this would be a good fit even for a minor release and when it's time for 2.0.0, we just change the default or even remove support for old extension.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants