Feature: Automatically detect zip encoding #17045
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxygen-dioxide
changed the title
yaira2
reviewed
Apr 22, 2025
yaira2
reviewed
Apr 22, 2025
src/Files.App/ViewModels/Dialogs/DecompressArchiveDialogViewModel.cs
Outdated
Show resolved
Hide resolved
yaira2
changed the title
yaira2
added
changes requested
Co-authored-by: Yair <[email protected]> Signed-off-by: oxygen-dioxide <[email protected]>
…del.cs Co-authored-by: Yair <[email protected]> Signed-off-by: oxygen-dioxide <[email protected]>
yaira2
added
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After this PR, when decompressing zip file and the encoding of zip file is undetermined, Files will detect the encoding autometically.
Before this PR, SharpZipLib decompressing (decompressing with specified encoding) blocks the UI. After this PR, it no longers blocks the UI and works like SevenZipSharp.
All possible Windows system encodings are added into the encoding list.
Resolved / Related Issues
To prevent extra work, all changes to the Files codebase must link to an approved issue marked as
Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.Steps used to test these changes
Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.
japanese-example.zip