Skip to content

Update pyo3 to 0.8. #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 8, 2019
Merged

Update pyo3 to 0.8. #59

merged 1 commit into from
Sep 8, 2019

Conversation

sebpuetz
Copy link
Member

@sebpuetz sebpuetz commented Sep 7, 2019

Prerequisite for fixing #51

@sebpuetz sebpuetz requested a review from danieldk September 7, 2019 10:42
@sebpuetz
Copy link
Member Author

sebpuetz commented Sep 7, 2019

I'm confused by the CI failures:

rustc version is 1.34, yet CI fails and I can't build locally either with the same toolchain.

@sebpuetz
Copy link
Member Author

sebpuetz commented Sep 7, 2019

pyo3 requires nightly-2019-07-19-x86_64-unknown-linux-gnu on 0.8

Copy link
Member

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but do we need all the updates in Cargo.lock? Or are they enforced by the pyo3 update? Seems like a lot of updates.

@danieldk
Copy link
Member

danieldk commented Sep 7, 2019

Looks good, but do we need all the updates in Cargo.lock? Or are they enforced by the pyo3 update? Seems like a lot of updates.

Seems like there are more errors (CI fail).

@sebpuetz
Copy link
Member Author

sebpuetz commented Sep 7, 2019

Looks good, but do we need all the updates in Cargo.lock? Or are they enforced by the pyo3 update? Seems like a lot of updates.

Looks like the rust plugin for CLion was doing its thing again. nevermind, just running pyo3-pack build --release changes a lot in Cargo.lock

Seems like there are more errors (CI fail).

I forgot to change the default toolchain, I had only updated the required rust version for travis-ci.

Copy link
Member

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the slow ack. I was fighting my own Rust battles ;).

@sebpuetz sebpuetz merged commit 7b5b7ae into master Sep 8, 2019
@sebpuetz sebpuetz deleted the pyo3-0.8 branch September 8, 2019 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants