-
Notifications
You must be signed in to change notification settings - Fork 4
Update pyo3 to 0.8. #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I'm confused by the CI failures:
rustc version is 1.34, yet CI fails and I can't build locally either with the same toolchain. |
pyo3 requires |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but do we need all the updates in Cargo.lock
? Or are they enforced by the pyo3 update? Seems like a lot of updates.
Seems like there are more errors (CI fail). |
I forgot to change the default toolchain, I had only updated the required rust version for travis-ci. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the slow ack. I was fighting my own Rust battles ;).
Prerequisite for fixing #51