-
Notifications
You must be signed in to change notification settings - Fork 130
feat: enable multiple auth methods #963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable multiple auth methods #963
Conversation
✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #963 +/- ##
==========================================
+ Coverage 48.49% 49.14% +0.64%
==========================================
Files 51 52 +1
Lines 2099 2110 +11
Branches 242 241 -1
==========================================
+ Hits 1018 1037 +19
+ Misses 1044 1036 -8
Partials 37 37 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Main concern is the hardcoded default admin user credentials
@sam-holmes2 Thanks for the review! I addressed most of the problems, and made extra issues for the things we should probably set aside for now. I think we could look into improving test coverage after the Important: #961 should be merged first as it makes these auth changes optional and configurable through |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks for your contribution!
Understood, #961 should be merged first (I've also approved this PR)
Fixes #962.
This PR builds on top of #961 and adds support for multiple auth methods. Now, it's possible to enable different methods simultaneously without erroring out (local, AD, OIDC).
I'm happy to add tests to improve coverage if needed. 🙂
Changelog
src/service/passport
src/service/routes/auth.js
routes accordingly/userLoggedIn
to more standard/me