fix: Always place the copy icon on the right side on mobile #177
+19
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for fipguide ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
MoritzWeber0
force-pushed
the
fix/copy-icon-mobile
branch
from
d71d92e to
0f8b538
Compare
MoritzWeber0
force-pushed
the
fix/copy-icon-mobile
branch
from
c0ab1ff to
0f8b538
Compare
|
I can understand very well why you changed it. I also find the current placement of the button annoying when it wraps in new line. However, I think the spacing is too large for a short headline or a larger screen width ._. |
|
maybe it´s sufficient to have the without wrapping? |
Not trivial. It still looks good for the headings without wrapping, but when wrapping occurs, the first elements takes more space than it needs (even if
|
|
It would be easier to place it left to the text:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of having the copy icon directly after the text (which produced some issues with multi-line texts), always place the the copy icon on the right side. It's easier to reach for right-handed people.
Not 100% sure if the link icon is still recognized with a connection to the title, so happy to hear any feedback.
Resolves #49