Multiple ignition points #89
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matildeRivas
requested changes
Jan 2, 2025
matildeRivas
reviewed
Jan 2, 2025
| else if (args.Ignitions == "raster") { | ||
|
|
||
| if (initialPoints.empty()) { | ||
| initialPoints = this->IgnitionPoints; |
matildeRivas
requested changes
Jan 2, 2025
| additional_args="" | ||
| sim_code="K" | ||
| fi | ||
| Cell2Fire$1 --input-instance-folder model/$model-$format --output-folder $output_folder --nsims 113 --ignitions-$ignition_mode --output-messages --grids --out-ros --out-intensity --sim ${sim_code} --seed 123 --ignitionsLog $additional_args > test_results/$model-$format-$ignition_mode/log.txt |
There was a problem hiding this comment.
El ignition mode tiene que ser el adecuado para que funcione el test. Aparte hay que hacer un chequeo del funcionamiento de los puntos múltiples.
There was a problem hiding this comment.
@matiasuno Resolviste esto?
matildeRivas
requested changes
Jan 2, 2025
Cell2Fire/Cell2Fire.cpp
Outdated
| @@ -780,7 +784,7 @@ bool Cell2Fire::RunIgnition(std::default_random_engine generator, int ep){ | |||
| std::uniform_int_distribution<int> distribution(1, this->nCells); | |||
|
|
|||
| // No Ignitions provided | |||
| if (this->args.Ignitions == 0) { | |||
| if (this->args.Ignitions == "random" || this->args.Ignitions == 0) { | |||
There was a problem hiding this comment.
El tipo de Ignition actualmente es Bool, tiene que pasarse a string.
There was a problem hiding this comment.
@matiasuno hiciste este cambio?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added ignitions-raster option to give a set of ignition points as