Skip to content

fix(firebase_ui_auth): Avoid redundant confirmation on account deletion #494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

EArminjon
Copy link

Description

When user try to delete his account, when the exception 'requires-recent-login' appear, user need to login again and click again on the modal to confirm the account deletion. That's redundant.

Related Issues

This PR can also bring some beneficts to this PR : #493, if developer override the deletion modal to provide one (for example) using a TextController to ensure that user well want to delete his account (no miss click), the recall of the confirmation will present twice a TextController to fill.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • All unit tests pass (melos run test:unit:all doesn't fail).
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@EArminjon EArminjon marked this pull request as draft April 16, 2025 14:44
@EArminjon EArminjon force-pushed the fix-avoid-redundant-confirmation-on-account-deletion branch from 9061f02 to e3c0323 Compare April 16, 2025 14:48
@EArminjon EArminjon marked this pull request as ready for review April 16, 2025 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant