Skip to content

chore(delete-user-data): bump to node 16 #1566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 2, 2023
Merged

chore(delete-user-data): bump to node 16 #1566

merged 5 commits into from
Jun 2, 2023

Conversation

cabljac
Copy link
Contributor

@cabljac cabljac commented May 31, 2023

  • test installs fine

@cabljac cabljac requested a review from a team as a code owner May 31, 2023 13:43
@cabljac cabljac force-pushed the @invertase/delete-data-node-16 branch from f8b3006 to 7a524b4 Compare May 31, 2023 14:04
@pr-Mais pr-Mais mentioned this pull request May 31, 2023
Closed
9 tasks
@pr-Mais
Copy link
Member

pr-Mais commented May 31, 2023

handleSearch and handleDeletion don't have a runtime, is the default nodejs16?

@cabljac
Copy link
Contributor Author

cabljac commented May 31, 2023 •
edited
Loading

handleSearch and handleDeletion don't have a runtime, is the default nodejs16?

I had this thought as well. I think runtime should be at least 16 but I will double check before merging, or perhaps we should add them explicitly?

@pr-Mais
Copy link
Member

pr-Mais commented May 31, 2023

guess it would be better if we add them explicitly

@pr-Mais
Copy link
Member

pr-Mais commented May 31, 2023

also let's move some dependencies to dev, per #1565

@pr-Mais pr-Mais self-assigned this Jun 1, 2023
@pr-Mais pr-Mais merged commit a9d602b into next Jun 2, 2023
@pr-Mais pr-Mais deleted the @invertase/delete-data-node-16 branch June 2, 2023 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dackers86 dackers86 dackers86 approved these changes

@pr-Mais pr-Mais pr-Mais approved these changes

Assignees

@pr-Mais pr-Mais

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cabljac @pr-Mais @dackers86