Refactor bom generation #6675
Merged
Refactor bom generation #6675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📝 PRs merging into main branchOur main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released. |
1 similar comment
📝 PRs merging into main branchOur main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released. |
Vertex AI Mock Responses Check
|
plugins test results66 tests 66 ✅ 1m 15s ⏱️ Results for commit b45fc48. |
Size Report 1Affected ProductsNo changes between base commit (92f448f) and merge commit (fd10f74).Test Logs |
rlazo
approved these changes
Feb 5, 2025
Coverage Report 1Affected Products
Test Logs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per b/394616465,
This refactors our bom generation and all of the bom related tasks to solve the following issues:
Effectively, this PR splits bom generation into 3 tasks:
GenerateBomTask,GenerateBomReleaseNotesTask, andGenerateTutorialBundleTask. These 3 tasks get ran together during the release, but them being separated now makes it easier to not only run them in isolation of each other- but test them in isolation. As such, this PR also includes tests for all of the bom related tasks, and documentation for everything. These tasks also take advantage of the newGMavenService- to support proper parallel execution and caching. And finally, the configuration of these tasks has been moved to the use-site instead of the declaration site, to more cleanly match other tasks and the configuration style that the Gradle team pushes.This PR also fixes the following: