Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support custom tabs in more browsers #6705

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Support custom tabs in more browsers #6705

wants to merge 3 commits into from
+4 −7

Conversation

Fry-kun
Copy link

@Fry-kun Fry-kun commented Feb 14, 2025

fixes #6692

@Fry-kun Fry-kun marked this pull request as draft February 14, 2025 23:22
@Fry-kun Fry-kun marked this pull request as ready for review February 14, 2025 23:29
lfkellogg
lfkellogg reviewed Feb 23, 2025
View reviewed changes
Copy link
Contributor

@lfkellogg lfkellogg left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add this to AndroidManifest.xml (under <manifest>):

    <queries>
        <intent>
            <action android:name="android.support.customtabs.action.CustomTabsService" />
        </intent>
    </queries>

Source: https://developer.android.com/reference/androidx/browser/customtabs/CustomTabsClient#getPackageName(android.content.Context,java.util.List%3Cjava.lang.String%3E,boolean)

@lfkellogg
Copy link
Contributor

BTW I tested this locally and confirmed it works on older (API level 29) and newer (API level 34) devices.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lfkellogg lfkellogg lfkellogg left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Custom tab handling not taking packages other than Chrome into account
3 participants
@Fry-kun @lfkellogg @google-oss-bot