fix: conversion to handle nanosecond precision timestamp #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
russellwheatley
changed the title
Salakar
reviewed
Jun 20, 2023
Salakar
reviewed
Jun 20, 2023
Salakar
reviewed
Jun 20, 2023
Salakar
approved these changes
Jun 21, 2023
exaby73
requested changes
Jun 22, 2023
exaby73
approved these changes
Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #95
To test, I hardcoded some timestamps with nanosecond precision into the code and ran from the emulator:
Here are the successful logs from the emulator changing the nanoseconds hardcoded:
I've also written tests for converting to nanosecond precision, microsecond precision and for detecting what type of timestamp it is here