Skip to content

feat: Add support for new Firestore types #14800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions FirebaseFirestoreInternal/FirebaseFirestore/FIRBsonBinaryData.h
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, these build failures are expected. I think it's acceptable to merge with the spm-binary workflow failing, and I'll fix right after. Another option is to build a zip off of this branch but that's only worth doing when the PR is final. Either way works–– we just need to update the SPM FST binary to include the new sources.

Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
// Copyright 2025 Google LLC
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

#import <FirebaseFirestoreInternal/FIRBsonBinaryData.h>

Check failure on line 15 in FirebaseFirestoreInternal/FirebaseFirestore/FIRBsonBinaryData.h

View workflow job for this annotation

GitHub Actions / spm-binary

'FirebaseFirestoreInternal/FIRBsonBinaryData.h' file not found

Check failure on line 15 in FirebaseFirestoreInternal/FirebaseFirestore/FIRBsonBinaryData.h

View workflow job for this annotation

GitHub Actions / spm-binary

'FirebaseFirestoreInternal/FIRBsonBinaryData.h' file not found

Check failure on line 15 in FirebaseFirestoreInternal/FirebaseFirestore/FIRBsonBinaryData.h

View workflow job for this annotation

GitHub Actions / spm-binary

'FirebaseFirestoreInternal/FIRBsonBinaryData.h' file not found

Check failure on line 15 in FirebaseFirestoreInternal/FirebaseFirestore/FIRBsonBinaryData.h

View workflow job for this annotation

GitHub Actions / spm-binary

'FirebaseFirestoreInternal/FIRBsonBinaryData.h' file not found

Check failure on line 15 in FirebaseFirestoreInternal/FirebaseFirestore/FIRBsonBinaryData.h

View workflow job for this annotation

GitHub Actions / spm-binary

'FirebaseFirestoreInternal/FIRBsonBinaryData.h' file not found
15 changes: 15 additions & 0 deletions FirebaseFirestoreInternal/FirebaseFirestore/FIRBsonObjectId.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
// Copyright 2025 Google LLC
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

#import <FirebaseFirestoreInternal/FIRBsonObjectId.h>
15 changes: 15 additions & 0 deletions FirebaseFirestoreInternal/FirebaseFirestore/FIRBsonTimestamp.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
// Copyright 2025 Google LLC
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

#import <FirebaseFirestoreInternal/FIRBsonTimestamp.h>
15 changes: 15 additions & 0 deletions FirebaseFirestoreInternal/FirebaseFirestore/FIRInt32Value.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
// Copyright 2025 Google LLC
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

#import <FirebaseFirestoreInternal/FIRInt32Value.h>
15 changes: 15 additions & 0 deletions FirebaseFirestoreInternal/FirebaseFirestore/FIRMaxKey.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
// Copyright 2025 Google LLC
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

#import <FirebaseFirestoreInternal/FIRMaxKey.h>
15 changes: 15 additions & 0 deletions FirebaseFirestoreInternal/FirebaseFirestore/FIRMinKey.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
// Copyright 2025 Google LLC
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

#import <FirebaseFirestoreInternal/FIRMinKey.h>
15 changes: 15 additions & 0 deletions FirebaseFirestoreInternal/FirebaseFirestore/FIRRegexValue.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
// Copyright 2025 Google LLC
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

#import <FirebaseFirestoreInternal/FIRRegexValue.h>
4 changes: 4 additions & 0 deletions Firestore/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
# Unreleased
- [feature] Adds support for the following new types: MinKey, MaxKey, RegexValue, Int32Value, BsonObjectId,
BsonTimestamp, and BsonBinaryData. (#14800)
Comment on lines +2 to +3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: code backticks and updated Bson to BSON

Suggested change
- [feature] Adds support for the following new types: MinKey, MaxKey, RegexValue, Int32Value, BsonObjectId,
BsonTimestamp, and BsonBinaryData. (#14800)
- [feature] Adds support for the following new types: `MinKey`, `MaxKey`, `RegexValue`, `Int32Value`, `BSONObjectId`,
`BSONTimestamp`, and `BSONBinaryData`. (#14800)


# 11.12.0
- [fixed] Fixed the `null` value handling in `isNotEqualTo` and `notIn` filters.

Expand Down
Loading
Loading