Skip to content

[Functions] Complete Swift 6 support #14838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 13, 2025
Merged

[Functions] Complete Swift 6 support #14838

merged 5 commits into from
May 13, 2025

Conversation

ncooke3
Copy link
Member

@ncooke3 ncooke3 commented May 9, 2025

This PR gets Function to complete Swift 6 support.

Note: I did add a TODO in the Functions error handling. In theory, it should be okay, but in practice, it will be hard to get checked Sendable until FunctionsSerializer no longer returns Any. This appears feasible but it will take some more investigation and I'd prefer to circle back to it to focus on others areas of Swift 6 compliance.

Reasoning for changes in FirebaseFunctions/Sources/HTTPSCallable.swift:

  • The sending param attribute does not bridge to ObjC. Even passing an immutable type from ObjC crashed the integration tests. To workaround, I'm marking the existing signature ObjC-only and adding a new Swift-only function with the sending param. It should otherwise match the existing signature and not be a break to Swift 5 clients because Sendability changes are non-breaking. The ObjC-only calls through to it with a SendableWrapper type that seems to appease the runtime.

#no-changelog

Copy link
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

@ncooke3 ncooke3 requested review from paulb777 and morganchen12 May 12, 2025 16:06
@ncooke3 ncooke3 merged commit dbecea0 into main May 13, 2025
91 checks passed
@ncooke3 ncooke3 deleted the nc/functions-sendable-2 branch May 13, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants