Skip to content

VertexAI: add test cases for countTokens() #8317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 18, 2024
Merged

VertexAI: add test cases for countTokens() #8317

merged 4 commits into from
Jun 18, 2024

Conversation

tanzimfh
Copy link
Contributor

This adds test cases for countTokens() using mock responses from iOS.

Background
I'm an intern on the Android core team, and part of the goal of my intern project is to improve VertexAI test coverage by sharing test cases between our client SDKs. This is a proof of concept of that.

@tanzimfh tanzimfh requested review from DellaBitta and dlarocque June 14, 2024 14:51
@tanzimfh tanzimfh requested a review from a team as a code owner June 14, 2024 14:51
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jun 14, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 3ef8a4d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 14, 2024 •
edited
Loading

Changeset File Check ⚠️

  • Changeset formatting error in following file:%0A %0A Some packages have been changed but no changesets were found. Run `changeset add` to resolve this error.%0A If this change doesn't need a release, run `changeset add --empty`.%0A %0A

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 14, 2024 •
edited
Loading

Size Report 1

Affected Products

No changes between base commit (a90255a) and merge commit (f6e2cd6).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/f5ypeAIpp5.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 14, 2024 •
edited
Loading

Size Analysis Report 1

Affected Products

No changes between base commit (a90255a) and merge commit (f6e2cd6).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/yLzrQmKq1I.html

@DellaBitta DellaBitta requested a review from hsubox76 June 14, 2024 15:40
@tanzimfh tanzimfh requested review from a team as code owners June 14, 2024 16:51
rlazo
rlazo reviewed Jun 18, 2024
View reviewed changes
.changeset/fuzzy-kids-grin.md Outdated
@@ -0,0 +1,2 @@
---
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this file intentionally "blank"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it was to pass the changeset check. I don't know if it's required, but @dlarocque said to add an empty one.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, you don't need to do this. Our changeset checker CI workflow is broken so it will error, but it's not a required check. Sorry about that.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my bad!

@tanzimfh tanzimfh requested a review from davidmotson June 18, 2024 17:23
hsubox76
hsubox76 approved these changes Jun 18, 2024
View reviewed changes
Copy link
Contributor

@hsubox76 hsubox76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tanzimfh tanzimfh merged commit 576c1b1 into master Jun 18, 2024
33 of 34 checks passed
@tanzimfh tanzimfh deleted the tanzim/coverage branch June 18, 2024 22:53
@firebase firebase locked and limited conversation to collaborators Jul 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rlazo rlazo rlazo left review comments

@hsubox76 hsubox76 hsubox76 approved these changes

@dlarocque dlarocque dlarocque approved these changes

@DellaBitta DellaBitta Awaiting requested review from DellaBitta

@davidmotson davidmotson Awaiting requested review from davidmotson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tanzimfh @google-oss-bot @rlazo @hsubox76 @dlarocque