Skip to content

Fix transport service retry logic condition (Solve issue: https://github.com/firebase/firebase-js-sdk/issues/8813) #8814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 6, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/floppy-schools-battle.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
'@firebase/performance': patch
'firebase': patch
---

Modify the retry mechanism to stop when remaining tries is less than or equal to zero, improving the robustness of the retry handling.
2 changes: 1 addition & 1 deletion packages/performance/src/services/transport_service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ export function resetTransportService(): void {
function processQueue(timeOffset: number): void {
setTimeout(() => {
// If there is no remainingTries left, stop retrying.
if (remainingTries === 0) {
if (remainingTries <= 0) {
return;
}

Expand Down
Loading