realppl type1 #8873
Open
realppl type1 #8873
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make execute and _onSnapshot free standing
TODO: limit to last/cursors TODO: getNewerDoc by collection group for database/documents
…pl-type1 # Conflicts: # packages/firestore/package.json # packages/firestore/src/api/pipeline.ts # packages/firestore/src/api/pipeline_impl.ts # packages/firestore/src/core/firestore_client.ts # packages/firestore/src/core/pipeline-util.ts # packages/firestore/src/lite-api/expressions.ts # packages/firestore/src/lite-api/pipeline.ts # packages/firestore/src/remote/watch_change.ts # packages/firestore/test/integration/api/pipeline.test.ts # packages/firestore/test/unit/specs/spec_builder.ts
…pl-type1 # Conflicts: # packages/firestore/lite/index.ts # packages/firestore/src/api/database_augmentation.ts # packages/firestore/src/api/pipeline_impl.ts # packages/firestore/src/lite-api/expressions.ts
wu-hui
force-pushed
the
wuandy/offppl-type1
branch
from
fd7583b to
d0436a9
Compare
wu-hui
requested review from
a team,
hsubox76,
erikeldridge,
visumickey,
avolkovi,
yoyomyo,
lisajian,
Xiaoshouzi-gh,
sam-gc,
pashanka,
mansisampat,
NhienLam,
zwu52,
maneesht,
tonyjhuang and
aashishpatil-g
as code owners
aligned to the style of backend implementation.
wu-hui
force-pushed
the
wuandy/offppl-type1
branch
from
d0436a9 to
3101d82
Compare
…xports. Fix some circular deps. Remove circular dep assert. Update missing externs.
wu-hui
force-pushed
the
wuandy/offppl-type1
branch
from
2e2873f to
a8d937b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.