Skip to content

fix: remove null value inclusion from != and not-in filter results #8915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 11, 2025
Merged

fix: remove null value inclusion from != and not-in filter results #8915

merged 3 commits into from
Apr 11, 2025

Conversation

milaGGL
Copy link
Contributor

@milaGGL milaGGL commented Apr 9, 2025 •
edited
Loading

@milaGGL milaGGL requested review from a team as code owners April 9, 2025 18:35
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 9, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: ec521eb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@firebase/firestore Patch
firebase Patch
@firebase/firestore-compat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 9, 2025 •
edited
Loading

Size Report 1

Affected Products

  • @firebase/firestore

    TypeBase (4e0f630)Merge (675acb9)Diff
    browser382 kB382 kB+44 B (+0.0%)
    main591 kB591 kB+58 B (+0.0%)
    module382 kB382 kB+44 B (+0.0%)
    react-native382 kB382 kB+44 B (+0.0%)

  • @firebase/firestore-lite

    TypeBase (4e0f630)Merge (675acb9)Diff
    browser113 kB113 kB+44 B (+0.0%)
    main155 kB155 kB+58 B (+0.0%)
    module113 kB113 kB+44 B (+0.0%)
    react-native113 kB113 kB+44 B (+0.0%)

  • bundle

    12 size changes

    TypeBase (4e0f630)Merge (675acb9)Diff
    firestore (CSI Auto Indexing Disable and Delete)272 kB273 kB+44 B (+0.0%)
    firestore (CSI Auto Indexing Enable)272 kB273 kB+44 B (+0.0%)
    firestore (Persistence)304 kB304 kB+44 B (+0.0%)
    firestore (Query Cursors)250 kB250 kB+44 B (+0.0%)
    firestore (Query)248 kB248 kB+44 B (+0.0%)
    firestore (Read data once)236 kB236 kB+44 B (+0.0%)
    firestore (Read Write w Persistence)328 kB328 kB+44 B (+0.0%)
    firestore (Realtime updates)238 kB238 kB+44 B (+0.0%)
    firestore (Transaction)215 kB215 kB+44 B (+0.0%)
    firestore (Write data)214 kB214 kB+44 B (+0.0%)
    firestore-lite (Query Cursors)104 kB104 kB+44 B (+0.0%)
    firestore-lite (Query)99.9 kB99.9 kB+44 B (+0.0%)

  • firebase

    TypeBase (4e0f630)Merge (675acb9)Diff
    firebase-compat.js794 kB794 kB+44 B (+0.0%)
    firebase-firestore-compat.js340 kB340 kB+44 B (+0.0%)
    firebase-firestore-lite.js131 kB131 kB+44 B (+0.0%)
    firebase-firestore.js440 kB441 kB+44 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/6yzvPg1SL3.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 9, 2025 •
edited
Loading

Size Analysis Report 1

Affected Products

  • @firebase/firestore

    • QueryFieldFilterConstraint

      Size

      TypeBase (4e0f630)Merge (675acb9)Diff
      size41.1 kB41.2 kB+44 B (+0.1%)
      size-with-ext-deps111 kB111 kB+44 B (+0.0%)

    • _internalAggregationQueryToProtoRunAggregationQueryRequest

      Size

      TypeBase (4e0f630)Merge (675acb9)Diff
      size37.2 kB37.2 kB+44 B (+0.1%)
      size-with-ext-deps107 kB107 kB+44 B (+0.0%)

    • _internalQueryToProtoQueryTarget

      Size

      TypeBase (4e0f630)Merge (675acb9)Diff
      size44.9 kB45.0 kB+44 B (+0.1%)
      size-with-ext-deps115 kB115 kB+44 B (+0.0%)

    • addDoc

      Size

      TypeBase (4e0f630)Merge (675acb9)Diff
      size133 kB133 kB+44 B (+0.0%)
      size-with-ext-deps205 kB205 kB+44 B (+0.0%)

    • aggregateQuerySnapshotEqual

      Size

      TypeBase (4e0f630)Merge (675acb9)Diff
      size39.9 kB39.9 kB+44 B (+0.1%)
      size-with-ext-deps110 kB110 kB+44 B (+0.0%)

    • and

      Size

      TypeBase (4e0f630)Merge (675acb9)Diff
      size42.5 kB42.5 kB+44 B (+0.1%)
      size-with-ext-deps113 kB113 kB+44 B (+0.0%)

    • deleteAllPersistentCacheIndexes

      Size

      TypeBase (4e0f630)Merge (675acb9)Diff
      size96.3 kB96.4 kB+44 B (+0.0%)
      size-with-ext-deps168 kB168 kB+44 B (+0.0%)

    • deleteDoc

      Size

      TypeBase (4e0f630)Merge (675acb9)Diff
      size123 kB124 kB+44 B (+0.0%)
      size-with-ext-deps195 kB195 kB+44 B (+0.0%)

    • disableNetwork

      Size

      TypeBase (4e0f630)Merge (675acb9)Diff
      size112 kB112 kB+44 B (+0.0%)
      size-with-ext-deps184 kB184 kB+44 B (+0.0%)

    • disablePersistentCacheIndexAutoCreation

      Size

      TypeBase (4e0f630)Merge (675acb9)Diff
      size96.3 kB96.3 kB+44 B (+0.0%)
      size-with-ext-deps168 kB168 kB+44 B (+0.0%)

    • enableIndexedDbPersistence

      Size

      TypeBase (4e0f630)Merge (675acb9)Diff
      size187 kB187 kB+44 B (+0.0%)
      size-with-ext-deps259 kB259 kB+44 B (+0.0%)

    • enableMultiTabIndexedDbPersistence

      Size

      TypeBase (4e0f630)Merge (675acb9)Diff
      size223 kB223 kB+44 B (+0.0%)
      size-with-ext-deps295 kB295 kB+44 B (+0.0%)

    • enableNetwork

      Size

      TypeBase (4e0f630)Merge (675acb9)Diff
      size112 kB112 kB+44 B (+0.0%)
      size-with-ext-deps184 kB184 kB+44 B (+0.0%)

    • enablePersistentCacheIndexAutoCreation

      Size

      TypeBase (4e0f630)Merge (675acb9)Diff
      size96.3 kB96.3 kB+44 B (+0.0%)
      size-with-ext-deps168 kB168 kB+44 B (+0.0%)

    • executeWrite

      Size

      TypeBase (4e0f630)Merge (675acb9)Diff
      size123 kB123 kB+44 B (+0.0%)
      size-with-ext-deps195 kB195 kB+44 B (+0.0%)

    • getAggregateFromServer

      Size

      TypeBase (4e0f630)Merge (675acb9)Diff
      size120 kB120 kB+44 B (+0.0%)
      size-with-ext-deps192 kB192 kB+44 B (+0.0%)

    • getCountFromServer

      Size

      TypeBase (4e0f630)Merge (675acb9)Diff
      size120 kB120 kB+44 B (+0.0%)
      size-with-ext-deps192 kB192 kB+44 B (+0.0%)

    • getDoc

      Size

      TypeBase (4e0f630)Merge (675acb9)Diff
      size154 kB154 kB+44 B (+0.0%)
      size-with-ext-deps226 kB226 kB+44 B (+0.0%)

    • getDocFromCache

      Size

      TypeBase (4e0f630)Merge (675acb9)Diff
      size104 kB104 kB+44 B (+0.0%)
      size-with-ext-deps176 kB176 kB+44 B (+0.0%)

    • getDocFromServer

      Size

      TypeBase (4e0f630)Merge (675acb9)Diff
      size154 kB154 kB+44 B (+0.0%)
      size-with-ext-deps226 kB226 kB+44 B (+0.0%)

    • getDocs

      Size

      TypeBase (4e0f630)Merge (675acb9)Diff
      size156 kB156 kB+44 B (+0.0%)
      size-with-ext-deps228 kB228 kB+44 B (+0.0%)

    • getDocsFromCache

      Size

      TypeBase (4e0f630)Merge (675acb9)Diff
      size112 kB112 kB+44 B (+0.0%)
      size-with-ext-deps184 kB184 kB+44 B (+0.0%)

    • getDocsFromServer

      Size

      TypeBase (4e0f630)Merge (675acb9)Diff
      size156 kB156 kB+44 B (+0.0%)
      size-with-ext-deps228 kB228 kB+44 B (+0.0%)

    • loadBundle

      Size

      TypeBase (4e0f630)Merge (675acb9)Diff
      size121 kB121 kB+44 B (+0.0%)
      size-with-ext-deps193 kB193 kB+44 B (+0.0%)

    • memoryEagerGarbageCollector

      Size

      TypeBase (4e0f630)Merge (675acb9)Diff
      size84.8 kB84.8 kB+44 B (+0.1%)
      size-with-ext-deps156 kB156 kB+44 B (+0.0%)

    • memoryLocalCache

      Size

      TypeBase (4e0f630)Merge (675acb9)Diff
      size106 kB106 kB+44 B (+0.0%)
      size-with-ext-deps178 kB178 kB+44 B (+0.0%)

    • memoryLruGarbageCollector

      Size

      TypeBase (4e0f630)Merge (675acb9)Diff
      size91.2 kB91.3 kB+44 B (+0.0%)
      size-with-ext-deps163 kB163 kB+44 B (+0.0%)

    • namedQuery

      Size

      TypeBase (4e0f630)Merge (675acb9)Diff
      size97.2 kB97.2 kB+44 B (+0.0%)
      size-with-ext-deps169 kB169 kB+44 B (+0.0%)

    • onSnapshot

      Size

      TypeBase (4e0f630)Merge (675acb9)Diff
      size156 kB156 kB+44 B (+0.0%)
      size-with-ext-deps228 kB228 kB+44 B (+0.0%)

    • onSnapshotsInSync

      Size

      TypeBase (4e0f630)Merge (675acb9)Diff
      size145 kB145 kB+44 B (+0.0%)
      size-with-ext-deps217 kB217 kB+44 B (+0.0%)

    • or

      Size

      TypeBase (4e0f630)Merge (675acb9)Diff
      size42.5 kB42.5 kB+44 B (+0.1%)
      size-with-ext-deps113 kB113 kB+44 B (+0.0%)

    • persistentLocalCache

      Size

      TypeBase (4e0f630)Merge (675acb9)Diff
      size183 kB183 kB+44 B (+0.0%)
      size-with-ext-deps255 kB255 kB+44 B (+0.0%)

    • persistentMultipleTabManager

      Size

      TypeBase (4e0f630)Merge (675acb9)Diff
      size219 kB219 kB+44 B (+0.0%)
      size-with-ext-deps291 kB291 kB+44 B (+0.0%)

    • persistentSingleTabManager

      Size

      TypeBase (4e0f630)Merge (675acb9)Diff
      size183 kB183 kB+44 B (+0.0%)
      size-with-ext-deps255 kB255 kB+44 B (+0.0%)

    • query

      Size

      TypeBase (4e0f630)Merge (675acb9)Diff
      size42.7 kB42.8 kB+44 B (+0.1%)
      size-with-ext-deps113 kB113 kB+44 B (+0.0%)

    • queryEqual

      Size

      TypeBase (4e0f630)Merge (675acb9)Diff
      size39.8 kB39.8 kB+44 B (+0.1%)
      size-with-ext-deps110 kB110 kB+44 B (+0.0%)

    • runTransaction

      Size

      TypeBase (4e0f630)Merge (675acb9)Diff
      size133 kB134 kB+44 B (+0.0%)
      size-with-ext-deps205 kB205 kB+44 B (+0.0%)

    • setDoc

      Size

      TypeBase (4e0f630)Merge (675acb9)Diff
      size132 kB132 kB+44 B (+0.0%)
      size-with-ext-deps204 kB204 kB+44 B (+0.0%)

    • setIndexConfiguration

      Size

      TypeBase (4e0f630)Merge (675acb9)Diff
      size99.7 kB99.8 kB+44 B (+0.0%)
      size-with-ext-deps171 kB171 kB+44 B (+0.0%)

    • snapshotEqual

      Size

      TypeBase (4e0f630)Merge (675acb9)Diff
      size45.5 kB45.5 kB+44 B (+0.1%)
      size-with-ext-deps116 kB116 kB+44 B (+0.0%)

    • updateDoc

      Size

      TypeBase (4e0f630)Merge (675acb9)Diff
      size133 kB133 kB+44 B (+0.0%)
      size-with-ext-deps205 kB205 kB+44 B (+0.0%)

    • waitForPendingWrites

      Size

      TypeBase (4e0f630)Merge (675acb9)Diff
      size112 kB113 kB+44 B (+0.0%)
      size-with-ext-deps184 kB184 kB+44 B (+0.0%)

    • where

      Size

      TypeBase (4e0f630)Merge (675acb9)Diff
      size41.9 kB42.0 kB+44 B (+0.1%)
      size-with-ext-deps112 kB112 kB+44 B (+0.0%)

    • writeBatch

      Size

      TypeBase (4e0f630)Merge (675acb9)Diff
      size135 kB135 kB+44 B (+0.0%)
      size-with-ext-deps207 kB207 kB+44 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/Yuoh5ag2BB.html

@milaGGL milaGGL requested a review from a team as a code owner April 10, 2025 18:57
@github-actions GitHub Actions
Copy link
Contributor

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_vertexai_responses.sh should be updated to clone the latest version of the responses: v9.0

@milaGGL milaGGL merged commit ed0803a into main Apr 11, 2025
104 of 120 checks passed
@milaGGL milaGGL deleted the mila/fix-incorrect-null-value-inclusion branch April 11, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehsannas ehsannas ehsannas approved these changes

@HourtashHAJI HourtashHAJI HourtashHAJI approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@milaGGL @google-oss-bot @ehsannas @HourtashHAJI