Skip to content

Revert "Fixed scroll behavior (#8977)" #9053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 20, 2025
Merged

Revert "Fixed scroll behavior (#8977)" #9053

merged 6 commits into from
May 20, 2025
+24 −47

Conversation

maneesht
Copy link
Contributor

@maneesht maneesht commented May 19, 2025 •
edited by hsubox76
Loading

Reverts #8977 but keeps changes to firebase/util

@maneesht maneesht requested a review from a team as a code owner May 19, 2025 23:39
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 19, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 7610e49

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
@firebase/auth Patch
@firebase/database Patch
@firebase/firestore Patch
@firebase/functions Patch
@firebase/storage Patch
@firebase/auth-compat Patch
firebase Patch
@firebase/database-compat Patch
@firebase/firestore-compat Patch
@firebase/functions-compat Patch
@firebase/storage-compat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_vertexai_responses.sh should be updated to clone the latest version of the responses: v13.0

@maneesht maneesht requested a review from a team as a code owner May 19, 2025 23:47
@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 19, 2025 •
edited
Loading

Size Report 1

Affected Products

  • @firebase/app-check

    TypeBase (880110b)Merge (3f031db)Diff
    browser26.9 kB26.9 kB+1 B (+0.0%)
    main27.9 kB27.9 kB+1 B (+0.0%)
    module26.9 kB26.9 kB+1 B (+0.0%)

  • @firebase/auth

    TypeBase (880110b)Merge (3f031db)Diff
    browser193 kB193 kB-100 B (-0.1%)
    cordova166 kB166 kB-60 B (-0.0%)
    main147 kB147 kB-44 B (-0.0%)
    module193 kB193 kB-100 B (-0.1%)
    react-native165 kB165 kB-44 B (-0.0%)

  • @firebase/auth-cordova

    TypeBase (880110b)Merge (3f031db)Diff
    browser166 kB166 kB-60 B (-0.0%)
    module166 kB166 kB-60 B (-0.0%)

  • @firebase/auth-web-extension

    TypeBase (880110b)Merge (3f031db)Diff
    browser142 kB142 kB-60 B (-0.0%)
    main159 kB159 kB-46 B (-0.0%)
    module142 kB142 kB-60 B (-0.0%)

  • @firebase/auth/internal

    TypeBase (880110b)Merge (3f031db)Diff
    browser204 kB204 kB-100 B (-0.0%)
    main174 kB174 kB-46 B (-0.0%)
    module204 kB204 kB-100 B (-0.0%)

  • @firebase/database

    TypeBase (880110b)Merge (3f031db)Diff
    browser250 kB249 kB-136 B (-0.1%)
    main255 kB254 kB-125 B (-0.0%)
    module250 kB249 kB-136 B (-0.1%)

  • @firebase/database-compat/standalone

    TypeBase (880110b)Merge (3f031db)Diff
    main367 kB366 kB-125 B (-0.0%)

  • @firebase/firestore

    TypeBase (880110b)Merge (3f031db)Diff
    browser385 kB385 kB-128 B (-0.0%)
    main596 kB596 kB-114 B (-0.0%)
    module385 kB385 kB-128 B (-0.0%)
    react-native385 kB385 kB-127 B (-0.0%)

  • @firebase/firestore-lite

    TypeBase (880110b)Merge (3f031db)Diff
    browser114 kB114 kB-127 B (-0.1%)
    main157 kB157 kB-114 B (-0.1%)
    module114 kB114 kB-127 B (-0.1%)
    react-native114 kB114 kB-130 B (-0.1%)

  • @firebase/functions

    TypeBase (880110b)Merge (3f031db)Diff
    browser14.2 kB14.1 kB-100 B (-0.7%)
    main14.8 kB14.7 kB-89 B (-0.6%)
    module14.2 kB14.1 kB-100 B (-0.7%)

  • @firebase/storage

    TypeBase (880110b)Merge (3f031db)Diff
    browser58.5 kB58.4 kB-96 B (-0.2%)
    main60.1 kB60.0 kB-85 B (-0.1%)
    module58.5 kB58.4 kB-96 B (-0.2%)

  • bundle

    37 size changes

    TypeBase (880110b)Merge (3f031db)Diff
    app-check (CustomProvider)38.0 kB38.0 kB+1 B (+0.0%)
    app-check (ReCaptchaEnterpriseProvider)40.5 kB40.5 kB+1 B (+0.0%)
    app-check (ReCaptchaV3Provider)40.5 kB40.5 kB+1 B (+0.0%)
    auth (GoogleFBTwitterGitHubPopup)109 kB105 kB-4.38 kB (-4.0%)
    database (Append to a list of data)154 kB150 kB-4.42 kB (-2.9%)
    database (Filtering data)153 kB149 kB-4.42 kB (-2.9%)
    database (Listen for child events)170 kB165 kB-4.42 kB (-2.6%)
    database (Listen for value events + Detach listeners)170 kB165 kB-4.42 kB (-2.6%)
    database (Listen for value events)170 kB165 kB-4.42 kB (-2.6%)
    database (Read data once)169 kB165 kB-4.42 kB (-2.6%)
    database (Save data as transactions)172 kB167 kB-4.42 kB (-2.6%)
    database (Sort data)155 kB151 kB-4.42 kB (-2.9%)
    database (Write data)154 kB149 kB-4.42 kB (-2.9%)
    firestore (CSI Auto Indexing Disable and Delete)280 kB275 kB-4.41 kB (-1.6%)
    firestore (CSI Auto Indexing Enable)280 kB275 kB-4.41 kB (-1.6%)
    firestore (Persistence)311 kB307 kB-4.41 kB (-1.4%)
    firestore (Query Cursors)256 kB252 kB-4.41 kB (-1.7%)
    firestore (Query)254 kB249 kB-4.41 kB (-1.7%)
    firestore (Read data once)242 kB237 kB-4.41 kB (-1.8%)
    firestore (Read Write w Persistence)335 kB331 kB-4.41 kB (-1.3%)
    firestore (Realtime updates)244 kB239 kB-4.41 kB (-1.8%)
    firestore (Transaction)221 kB216 kB-4.41 kB (-2.0%)
    firestore (Write data)220 kB216 kB-4.41 kB (-2.0%)
    firestore-lite (Query Cursors)109 kB105 kB-4.41 kB (-4.0%)
    firestore-lite (Query)105 kB101 kB-4.41 kB (-4.2%)
    firestore-lite (Read data once)80.7 kB76.3 kB-4.41 kB (-5.5%)
    firestore-lite (Transaction)106 kB102 kB-4.41 kB (-4.2%)
    firestore-lite (Write data)90.3 kB85.9 kB-4.41 kB (-4.9%)
    functions (call)39.4 kB35.0 kB-4.38 kB (-11.1%)
    storage (getBytes)47.2 kB42.8 kB-4.38 kB (-9.3%)
    storage (getDownloadURL)49.3 kB44.9 kB-4.38 kB (-8.9%)
    storage (getMetadata)48.7 kB44.3 kB-4.38 kB (-9.0%)
    storage (list + listAll)48.1 kB43.8 kB-4.38 kB (-9.1%)
    storage (updateMetadata)49.0 kB44.6 kB-4.38 kB (-8.9%)
    storage (uploadBytes)53.8 kB49.5 kB-4.38 kB (-8.1%)
    storage (uploadBytesResumable)63.8 kB59.4 kB-4.38 kB (-6.9%)
    storage (uploadString)54.0 kB49.7 kB-4.38 kB (-8.1%)

  • firebase

    16 size changes

    TypeBase (880110b)Merge (3f031db)Diff
    firebase-app-check-compat.js23.1 kB23.1 kB+1 B (+0.0%)
    firebase-app-check.js25.5 kB25.5 kB+1 B (+0.0%)
    firebase-auth-compat.js145 kB141 kB-4.12 kB (-2.8%)
    firebase-auth-cordova.js142 kB138 kB-4.45 kB (-3.1%)
    firebase-auth-web-extension.js125 kB121 kB-4.45 kB (-3.6%)
    firebase-auth.js163 kB158 kB-4.49 kB (-2.8%)
    firebase-compat.js802 kB798 kB-4.31 kB (-0.5%)
    firebase-database-compat.js168 kB164 kB-4.19 kB (-2.5%)
    firebase-database.js192 kB187 kB-4.54 kB (-2.4%)
    firebase-firestore-compat.js347 kB343 kB-4.18 kB (-1.2%)
    firebase-firestore-lite.js137 kB133 kB-4.53 kB (-3.3%)
    firebase-firestore.js449 kB444 kB-4.53 kB (-1.0%)
    firebase-functions-compat.js14.7 kB10.5 kB-4.15 kB (-28.2%)
    firebase-functions.js19.5 kB15.0 kB-4.51 kB (-23.1%)
    firebase-storage-compat.js44.2 kB40.1 kB-4.13 kB (-9.3%)
    firebase-storage.js51.2 kB46.7 kB-4.49 kB (-8.8%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/nnq3hZcpY5.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 20, 2025 •
edited
Loading

Size Analysis Report 1

This report is too large (401,194 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/TgxQN5YP2f.html

@hsubox76 hsubox76 changed the title Revert "Fixed scroll behavior (#9043)" Revert "Fixed scroll behavior (#8977)" May 20, 2025
@hsubox76 hsubox76 merged commit 35ad526 into main May 20, 2025
55 of 58 checks passed
@hsubox76 hsubox76 deleted the mtewani/fix-banner-link branch May 20, 2025 18:32
@google-oss-bot google-oss-bot mentioned this pull request May 20, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsubox76 hsubox76 hsubox76 approved these changes

@lisajian lisajian Awaiting requested review from lisajian lisajian is a code owner

@Xiaoshouzi-gh Xiaoshouzi-gh Awaiting requested review from Xiaoshouzi-gh Xiaoshouzi-gh is a code owner

@sam-gc sam-gc Awaiting requested review from sam-gc sam-gc is a code owner

@pashanka pashanka Awaiting requested review from pashanka pashanka is a code owner

@mansisampat mansisampat Awaiting requested review from mansisampat mansisampat is a code owner

@NhienLam NhienLam Awaiting requested review from NhienLam NhienLam is a code owner

@tonyjhuang tonyjhuang Awaiting requested review from tonyjhuang tonyjhuang is a code owner

@aashishpatil-g aashishpatil-g Awaiting requested review from aashishpatil-g aashishpatil-g is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maneesht @google-oss-bot @hsubox76