-
Notifications
You must be signed in to change notification settings - Fork 962
fix(firestore): revert fix for undefined
document snapshot data after "clear site data"
#9162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(firestore): revert fix for undefined
document snapshot data after "clear site data"
#9162
Conversation
🦋 Changeset detectedLatest commit: ad06f41 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Size Report 1Affected Products
Test Logs |
Size Analysis Report 1Affected Products
Test Logs |
This PR reverts #8871 which fixed #8593, a bug where an irrecoverable
undefined
document snapshot would be produced after the user clicked "Clear Site Data" in the web browser.The fix is being reverted because it has unintended consequences, such as #9056, where the Firestore instance was erroneously rendered useless. This same problem began to surface in Firestore's continuous integration tests, suggesting more widespread negative user impacts than intended.
Fixes #9056