[Firebase AI] Add thought summary and signature support #9192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2a82810 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
cc: @dlarocque |
hsubox76
reviewed
Aug 8, 2025
Size Report 1Affected Products
Test Logs |
Size Analysis Report 1Affected Products
Test Logs |
dlarocque
reviewed
Aug 13, 2025
rachelsaunders
requested changes
Aug 13, 2025
| @@ -23,12 +23,15 @@ export interface EnhancedGenerateContentResponse extends GenerateContentResponse | |||
|
|
|||
| | Property | Type | Description | | |||
| | --- | --- | --- | | |||
| | [functionCalls](./ai.enhancedgeneratecontentresponse.md#enhancedgeneratecontentresponsefunctioncalls) | () => [FunctionCall](./ai.functioncall.md#functioncall_interface)<!-- -->\[\] \| undefined | | | |||
| | [functionCalls](./ai.enhancedgeneratecontentresponse.md#enhancedgeneratecontentresponsefunctioncalls) | () => [FunctionCall](./ai.functioncall.md#functioncall_interface)<!-- -->\[\] \| undefined | Aggregates and returns all [FunctionCall](./ai.functioncall.md#functioncall_interface)<!-- -->s from the [GenerateContentResponse](./ai.generatecontentresponse.md#generatecontentresponse_interface)<!-- -->'s first candidate. | | |||
There was a problem hiding this comment.
NOT BLOCKING
...returns all FunctionCalls from...
We shouldn't pluralize like this.
Instead, tweak the sentence so that you're not pluralizing. Something like:
"... returns every FunctionCall from the..."
(same comment for GenerateContentResponse and a couple other similar instances throughout)
There was a problem hiding this comment.
Did a search for }s and updated all of them.
dlarocque
approved these changes
Aug 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for including thought summaries and thought signatures.
Edits by @hsubox76:
thoughtSignatureis not meant to be exposed publicly but needs to be stored in chat history, so it's marked internal to keep it out of public typings and docs, but still exists in the type so it can be used in chat validation and testingaddHelpers()functionCalls()method