Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vertexai): Imagen JPEG compression quality out of range warning #17178

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cynthiajoan
Copy link
Collaborator

Description

Added a warning log message if a value outside the range [0, 100] is specified for the JPEG compression quality in ImagenImageFormat.jpeg(compressionQuality:). Values outside this range seem to be treated as 0 or 100 by the backend and were likely set by accident. See b/395693541 (Google internal) for more details.

Related Issues

Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Copy link
Contributor

@natebosch natebosch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we consider making this throw an Error? We could check with RangeError.checkValueInInterval which throws an appropriate RangeError when the value is invalid.

Are the reasons an author would prefer to ignore an invalid quality argument?

@cynthiajoan
Copy link
Collaborator Author

Should we consider making this throw an Error? We could check with RangeError.checkValueInInterval which throws an appropriate RangeError when the value is invalid.

Are the reasons an author would prefer to ignore an invalid quality argument?

I think because backend will still work based on b/395693541, so it doesn't have to be an error? From developer's perspective I can accept either scenario, also iOS/JS is treating this as a warning other than an error.

@natebosch
Copy link
Contributor

I think because backend will still work

Matching the backend behavior is a good reason. SGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants