-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cloud_firestore): correct nanoseconds calculation for pre-1970 dates #17195
Open
SelaseKay
wants to merge
4
commits into
main
Choose a base branch
from
firestore_17189
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+55
−2
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
cb4b6d4
fix(cloud_firestore): correct nanoseconds calculation for pre-1970 dates
SelaseKay 024e0f4
chore: add test to ensure Timestamp.fromDate handles pre-1970 dates c…
SelaseKay 6484c79
chore: add native implementation reference
SelaseKay d3dca0a
chore: add more tests
SelaseKay File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -80,5 +80,34 @@ void main() { | |
|
||
expect(epoch, equals(-9999999999)); | ||
}); | ||
|
||
test('Timestamp should not throw for dates before 1970', () { | ||
final dates = [ | ||
DateTime(1969, 06, 22, 0, 0, 0, 123), | ||
DateTime(1969, 12, 31, 23, 59, 59, 999), | ||
DateTime(1900, 01, 01, 12, 30, 45, 500), | ||
DateTime(1800, 07, 04, 18, 15, 30, 250), | ||
DateTime(0001, 01, 01, 00, 00, 00, 001), | ||
]; | ||
|
||
for (final date in dates) { | ||
try { | ||
final timestamp = Timestamp.fromDate(date); | ||
expect(timestamp, isA<Timestamp>()); | ||
} catch (e) { | ||
fail('Timestamp.fromDate threw an error: $e'); | ||
} | ||
} | ||
}); | ||
Comment on lines
+84
to
+101
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You should be able to go from Date to Timestamp to Date and check that the value is still correct. |
||
|
||
test( | ||
'pre-1970 Timestamps should match the original DateTime after conversion', | ||
() { | ||
final date = DateTime(1969, 06, 22, 0, 0, 0, 123); | ||
final timestamp = Timestamp.fromDate(date); | ||
final timestampAsDateTime = timestamp.toDate(); | ||
|
||
expect(date, equals(timestampAsDateTime)); | ||
}); | ||
}); | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SelaseKay
Also the factory
fromMillisecondsSinceEpoch
should be fixed.I personally would delegate the milliseconds one to the microseconds one:
but I don't know if there are other considerations to be done