Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a sample for streaming callables #1185

Merged
merged 11 commits into from
Feb 3, 2025
Merged

Conversation

jhuleatt
Copy link
Collaborator

No description provided.

@jhuleatt jhuleatt requested review from egilmorez and taeold January 16, 2025 19:43
@jhuleatt jhuleatt force-pushed the jhuleatt-streaming-callables branch from aba908f to e23b2a1 Compare January 31, 2025 19:09
@jhuleatt jhuleatt marked this pull request as ready for review January 31, 2025 22:00
Copy link
Contributor

@egilmorez egilmorez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you pivoted to weather; SGTM! Does it basically iterate, sending each forecast as a chunk?

Also -- were. you going to add a tag in the client-side bit as well Jeff? Thanks!

Copy link
Contributor

@egilmorez egilmorez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jhuleatt jhuleatt merged commit 814a99a into main Feb 3, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants