Add information about v2 to readme files #985
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egilmorez
approved these changes
May 11, 2022
There was a problem hiding this comment.
A couple of thoughts, possibly out of scope :)
Confused by the diff; I can't see the instances of "usecases" in the markdown -- those should be "use cases," and it would be nice to lead into that chunk with a verb like the other items.
v2 material all LG, thanks!
README.md
Outdated
| @@ -18,6 +18,7 @@ To learn how to get started with Cloud Functions for Firebase by having a look a | |||
| This repository contains a few categories of samples: | |||
|
|
|||
| 1. [**Quickstarts**](#quickstarts) are minimal examples for each types of triggers. | |||
| 1. [**Cloud Functions v2 public preview**](#v2) samples show how to use the public preview of [Cloud Functions for Firebase v2](https://firebase.google.com/docs/functions/beta). | |||
| 1. [**Development Environment Samples and Boilerplates**](#environment) illustrates how to get started with | |||
| different, commonly used JavaScript development patterns such as Typescript, React SSR, ES2017 etc... | |||
| 1. [**Image Processing**](#image) shows a few ways where you can process and transform images using Cloud Functions such as generating thumbnails, converting images extracting metadata... | |||
There was a problem hiding this comment.
This could just be "a few ways you can process"
README.md
Outdated
| @@ -18,6 +18,7 @@ To learn how to get started with Cloud Functions for Firebase by having a look a | |||
| This repository contains a few categories of samples: | |||
|
|
|||
| 1. [**Quickstarts**](#quickstarts) are minimal examples for each types of triggers. | |||
| 1. [**Cloud Functions v2 public preview**](#v2) samples show how to use the public preview of [Cloud Functions for Firebase v2](https://firebase.google.com/docs/functions/beta). | |||
| 1. [**Development Environment Samples and Boilerplates**](#environment) illustrates how to get started with | |||
| different, commonly used JavaScript development patterns such as Typescript, React SSR, ES2017 etc... | |||
There was a problem hiding this comment.
Suggest "SSR, and ES2017."
I'd do the same with the next two ellipses below. "Such as" lets you give a few examples, but suggests more.
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.