-
Notifications
You must be signed in to change notification settings - Fork 7.4k
refactor(database): use Jetpack's Navigation Component #1252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
samtstern
merged 10 commits into
firebase:master
from
thatfiredev:rpf-database-navigation
Feb 1, 2021
Merged
refactor(database): use Jetpack's Navigation Component #1252
samtstern
merged 10 commits into
firebase:master
from
thatfiredev:rpf-database-navigation
Feb 1, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thatfiredev
commented
Jan 28, 2021
database/app/src/main/java/com/google/firebase/quickstart/database/java/MainActivity.java
Outdated
Show resolved
Hide resolved
16 tasks
samtstern
approved these changes
Jan 29, 2021
@rosariopfernandes thank you so much for being so careful about snippets as you do this. That's really helpful. So here's what we'll do:
|
This one is ready to go! Internal change is in so this should be safe. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1217, this should implement the Navigation Component in our database quickstart.
Extra changes
In order to accommodate the Navigation implementation, some extra changes took place here:
NewPostTest
unit test class which was testing one of our activities that no longer exists.AppTheme.NoActionBar
theme because it was causing the systembar to disappear.fragment
package which contains the fragments used in aTabLayout
was renamed tolistfragments
to avoid any confusion.CommentViewHolder
out of thePostDetailActivity
class and into a separate class in theviewholder
package (now sitting pretty alongside its brotherPostViewHolder
).Snippets moved to firebase/snippets-android
See firebase/snippets-android#275
@samtstern there are some snippets that are present in this repo, but I can't find them in the docs.
For example, the
my_top_posts_query
, which is similar to another snippet already present in snippets-android:quickstart-android
quickstart-android/database/app/src/main/java/com/google/firebase/quickstart/database/java/fragment/MyTopPostsFragment.java
Lines 12 to 17 in 49bcffe
snippets-android
https://github.com/firebase/snippets-android/blob/45ba4822eb111609be2951c944142e3bbe891472/database/app/src/main/java/com/google/firebase/referencecode/database/QueryActivity.java#L98-L113
I can see its usage in the docs: https://firebase.google.com/docs/database/android/lists-of-data#sort_data
Snippets in a similar situation include:
comment_class
,single_value_read
anddeclare_database_ref
. Is it possible to check these against the snippet registry?