refactor(auth): use Jetpack's Navigation Component #1265
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
create ChooserFragment create CustomAuthFragment create EmailPasswordFragment create FacebookLoginFragment create FirebaseUIFragment create GenericIdpFragment create GoogleSignInFragment create PasswordlessFragment create PhoneAuthFragment create MFA Fragments
16 tasks
thatfiredev
commented
Mar 15, 2021
auth/app/src/main/java/com/google/firebase/quickstart/auth/java/AnonymousAuthFragment.java
Outdated
Show resolved
Hide resolved
auth/app/src/main/java/com/google/firebase/quickstart/auth/java/ChooserFragment.java
Outdated
Show resolved
Hide resolved
auth/app/src/main/java/com/google/firebase/quickstart/auth/kotlin/MultiFactorSignInFragment.kt
Outdated
Show resolved
Hide resolved
auth/app/src/main/java/com/google/firebase/quickstart/auth/kotlin/MultiFactorSignInFragment.kt
Outdated
Show resolved
Hide resolved
thatfiredev
force-pushed
the
rpf-auth-navlibrary
branch
from
0b6569c to
0c3434e
Compare
samtstern
approved these changes
Mar 15, 2021
|
@rosariopfernandes this is perfect, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1217, this PR should introduce the Navigation Library to the auth module.
Changelist:
Activityclasses into Fragments. The only one that is still an Activity is thePasswordlessActivitybecause it has an Intent Filter declared on theAndroidManifest.xmlfile.